Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dynamic_links)!: rework as part of #6979 #7263

Merged
merged 132 commits into from
Dec 4, 2021
Merged

refactor(dynamic_links)!: rework as part of #6979 #7263

merged 132 commits into from
Dec 4, 2021

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 28, 2021 •
edited
Loading

Description

Dynamic links rework as part of #6979

iOS

  • Removed method application:openURL:sourceApplication:annotation: as the documentation states its for iOS 8 & older when the deployment target of dynamic link iOS is 10.0. See here
  • iOS doesn't support multi-app but android does. I've implemented multi-app support for android, but the package will throw an exception if the user tries to use multi-app for iOS.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@russellwheatley russellwheatley marked this pull request as draft October 28, 2021 16:10
@russellwheatley russellwheatley changed the title refactor(dynamic_links): rework initial commit refactor(dynamic_links): rework as part of #6979 Oct 28, 2021
@russellwheatley russellwheatley changed the title refactor(dynamic_links): rework as part of #6979 refactor(dynamic_links)!: rework as part of #6979 Oct 28, 2021
@russellwheatley
refactor(dynamic_links, android): rewire streamHandler
dbb6061
@russellwheatley
chore: format run formatter
71adce8
@russellwheatley
chore: not in android util
9d97169
@russellwheatley
refactor(dynamic_links, android): implement onLink stream handler
644bd3c
@russellwheatley
chore(dynamic_links, iOS): update folder structure
43fdda1
@russellwheatley
refactor(dynamic_links): previewLink is nullable
ab36616
@russellwheatley
format: run formatter
6f22500
@russellwheatley
chore: remove unused stream handler
118c769
@russellwheatley
chore(dynamic_links): miscellaneous xCode changes
3b639ac
@russellwheatley
chore(dynamic_links, ios): make header file public
53179a3
@russellwheatley
refactor(dynamic_links, ios): rework plugin
e15f561
@russellwheatley
chore: update note
2647009
@russellwheatley
format: run formatter
e2b45ec
@russellwheatley
Merge branch 'master' into @russell/dynamiclink-rework
b0acfe4 
# Conflicts:
#	packages/firebase_dynamic_links/firebase_dynamic_links/android/build.gradle
@russellwheatley
refactor(dynamic_links): update error handling
c2e1b56
@russellwheatley
chore(dynamic_links): update paths post directory restructuring
ed2b44b
@russellwheatley
chore(dynamic_links): update pubspec.yaml
5e436c3
@russellwheatley
chore(dynamic_links): started update of example app
9ecbb62
Ehesp
Ehesp requested changes Nov 8, 2021
View reviewed changes
Copy link
Member

@Ehesp Ehesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header licensing + the ignore_for_file should be removed on most files.

...ud_firestore_platform_interface/lib/src/platform_interface/platform_interface_firestore.dart Outdated Show resolved Hide resolved
packages/firebase_dynamic_links/firebase_dynamic_links/lib/src/firebase_dynamic_links.dart Outdated Show resolved Hide resolved
packages/firebase_dynamic_links/firebase_dynamic_links/lib/src/dynamic_link_builder.dart Outdated Show resolved Hide resolved
packages/firebase_dynamic_links/firebase_dynamic_links/lib/src/dynamic_link_builder.dart Outdated Show resolved Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_dynamic_links.dart Outdated Show resolved Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_dynamic_links.dart Outdated Show resolved Hide resolved
...s_platform_interface/lib/src/platform_interface/platform_interface_dynamic_link_builder.dart Outdated Show resolved Hide resolved
...mic_links_platform_interface/lib/src/method_channel/method_channel_dynamic_link_builder.dart Outdated Show resolved Hide resolved
...c_links_platform_interface/lib/src/method_channel/method_channel_firebase_dynamic_links.dart Outdated Show resolved Hide resolved
..._links/firebase_dynamic_links_platform_interface/lib/src/method_channel/utils/exception.dart Outdated Show resolved Hide resolved
@russellwheatley russellwheatley mentioned this pull request Dec 2, 2021
Closed
@Salakar Salakar changed the base branch from master to dev December 3, 2021 15:51
@Salakar Salakar merged commit 4d51bff into dev Dec 4, 2021
@Salakar Salakar deleted the @russell/dynamiclink-rework branch December 4, 2021 14:51
Salakar added a commit that referenced this pull request Dec 7, 2021
@russellwheatley @Ehesp @Salakar
refactor(dynamic_links)!: rework as part of #6979 (#7263)
9476444 
Co-authored-by: Elliot Hesp <[email protected]>
Co-authored-by: Salakar <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ehesp Ehesp Ehesp requested changes

@Salakar Salakar Awaiting requested review from Salakar Salakar is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russellwheatley @Ehesp @Salakar