Nexus serialization #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/FirebladeECS/Nexus.swift
# Conflicts: # Sources/FirebladeECS/Nexus.swift
# Conflicts: # Sources/FirebladeECS/ComponentIdentifier.swift # Sources/FirebladeECS/EntityIdentifierGenerator.swift # Tests/FirebladeECSTests/EntityTests.swift # Tests/FirebladeECSTests/XCTestManifests.swift
# Conflicts: # Tests/FirebladeECSTests/XCTestManifests.swift
ctreffs
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 98.09% 94.31% -3.79%
==========================================
Files 30 27 -3
Lines 1368 1214 -154
==========================================
- Hits 1342 1145 -197
- Misses 26 69 +43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add serialization for the whole Nexus.
There are several challenges with this, but especially the static types on deserialization make it hard to get it right.
For now arbitrary components are serialized into a binary format, but this should not be the final solution since this will produce a platform dependent and unstable serialization format.