Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constraints support and new tests #115

Merged
merged 15 commits into from
Jan 18, 2024
Merged

feat: constraints support and new tests #115

merged 15 commits into from
Jan 18, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Jan 17, 2024

Resolves #103

Description

Adding new tests and constraints support to be compatible with dbt 1.5

Setting threads to 1 in order to avoid race conditions when multiple tests use the same table name. Once we have user schema support we can re enable it in order to speed up the testing.

Bumping Python version from 3.7 to 3.9, since there are some issues with inheritance resolution in pytest - overrides are not taken into account and base class fixtures and tests are run therefore failing the whole test suite.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ptiurin ptiurin marked this pull request as ready for review January 18, 2024 11:30
@ptiurin ptiurin requested a review from a team as a code owner January 18, 2024 11:30
@ptiurin ptiurin merged commit ba92652 into main Jan 18, 2024
11 of 13 checks passed
@ptiurin ptiurin deleted the feat-update-1.5 branch January 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to support dbt-core v1.5.0
2 participants