Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CI artifacts #3890

Closed
wants to merge 23 commits into from
Closed

New CI artifacts #3890

wants to merge 23 commits into from

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Jun 27, 2023

Changes

  • Build new CI artifacts (kernels / rootfs)
  • Many refactors and cleanups

Reason

We need to track new stable kernels and new rootfs.

Our existing Ubuntu 18.04 is now end-of-life.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting author Indicates that an issue or pull request requires author action python Pull requests that update Python code labels Jun 27, 2023
@pb8o pb8o self-assigned this Jun 27, 2023
dependabot bot and others added 14 commits June 27, 2023 10:45
@dependabot @JonathanWoollett-Light
build(deps): Bump serde_spanned from 0.6.2 to 0.6.3
ce35ee1 
Bumps [serde_spanned](https://github.com/toml-rs/toml) from 0.6.2 to 0.6.3.
- [Commits](toml-rs/toml@serde_spanned-v0.6.2...serde_spanned-v0.6.3)

---
updated-dependencies:
- dependency-name: serde_spanned
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump clap from 4.3.5 to 4.3.8
52f2591 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.5 to 4.3.8.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.5...v4.3.8)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump toml_datetime from 0.6.2 to 0.6.3
467d25d 
Bumps [toml_datetime](https://github.com/toml-rs/toml) from 0.6.2 to 0.6.3.
- [Commits](toml-rs/toml@toml_datetime-v0.6.2...toml_datetime-v0.6.3)

---
updated-dependencies:
- dependency-name: toml_datetime
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump proc-macro2 from 1.0.60 to 1.0.63
25a0ee9 
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.60 to 1.0.63.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.60...1.0.63)

---
updated-dependencies:
- dependency-name: proc-macro2
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump toml from 0.7.4 to 0.7.5
c562ebd 
Bumps [toml](https://github.com/toml-rs/toml) from 0.7.4 to 0.7.5.
- [Commits](toml-rs/toml@toml-v0.7.4...toml-v0.7.5)

---
updated-dependencies:
- dependency-name: toml
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump serde_json from 1.0.97 to 1.0.99
0cd9c84 
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.97 to 1.0.99.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.97...v1.0.99)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump aws-lc-rs from 1.1.0 to 1.2.0
1f548da 
Bumps [aws-lc-rs](https://github.com/awslabs/aws-lc-rs) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/awslabs/aws-lc-rs/releases)
- [Commits](aws/aws-lc-rs@v1.1.0...v1.2.0)

---
updated-dependencies:
- dependency-name: aws-lc-rs
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@JonathanWoollett-Light
build(deps): Bump libc from 0.2.146 to 0.2.147
b0dd6a1 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.146 to 0.2.147.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Commits](rust-lang/libc@0.2.146...0.2.147)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: Jonathan Woollett-Light <[email protected]>
Co-authored-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump proc-macro2
44d40da 
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.60 to 1.0.63.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.60...1.0.63)

---
updated-dependencies:
- dependency-name: proc-macro2
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump libc in /tests/integration_tests/security/demo_seccomp
ca2e883 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.146 to 0.2.147.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Commits](rust-lang/libc@0.2.146...0.2.147)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump serde_json
ecc85c6 
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.97 to 1.0.99.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.97...v1.0.99)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump libc from 0.2.146 to 0.2.147 in /tests/host_tools/uffd
c92fa87 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.146 to 0.2.147.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Commits](rust-lang/libc@0.2.146...0.2.147)

---
updated-dependencies:
- dependency-name: libc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump serde_json in /tests/host_tools/uffd
55ce019 
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.97 to 1.0.99.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.97...v1.0.99)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @JonathanWoollett-Light
build(deps): Bump proc-macro2 in /tests/host_tools/uffd
9a9d863 
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.60 to 1.0.63.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.60...1.0.63)

---
updated-dependencies:
- dependency-name: proc-macro2
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
roypat
roypat reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so there some review comments in here that refer to commits that are no longer here, lets see how github handles that lol

tests/host_tools/cargo_build.py Show resolved Hide resolved
tests/framework/utils_vsock.py Show resolved Hide resolved
tests/integration_tests/performance/test_snapshot_restore_performance.py Show resolved Hide resolved
tests/integration_tests/performance/test_network_latency.py Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/framework/microvm.py Outdated Show resolved Hide resolved
tests/framework/microvm.py Outdated Show resolved Hide resolved
tests/framework/jailer.py Outdated Show resolved Hide resolved
tests/framework/microvm.py Outdated Show resolved Hide resolved
tests/framework/microvm.py Outdated Show resolved Hide resolved
@pb8o pb8o force-pushed the cleanups-3 branch 2 times, most recently from ea23437 to 047685c Compare June 27, 2023 12:47
@roypat
refactor: Remove unused bindings
eb41867 
Removes the unused bindings in `src/net_gen/src/inn.rs`.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
@pb8o pb8o force-pushed the cleanups-3 branch 2 times, most recently from 934718e to 7cbc590 Compare June 27, 2023 15:07
pb8o added 5 commits June 27, 2023 17:20
@pb8o
test: move pytest filterwarnings to pytest.ini
428c97a 
This helps when not running pytest thorough devtool.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
test: refactor cpu-template-helper into cargo_build
c88cd55 
Provide a general way to get a binary from Cargo.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
test: remove unused code
816a3ac 
The only usage was removed in 5bb8605

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
refactor(devtool): delete create_snapshot_artifacts command
95e00f6 
We can just call it through `devtool sh`.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
test: make test_5_snapshots faster
7b49a87 
By using 1MB blob files, it finishes in 30s instead of 180s.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o force-pushed the cleanups-3 branch 2 times, most recently from a529803 to a4a0b0d Compare June 27, 2023 17:44
pb8o added 3 commits June 27, 2023 19:46
@pb8o
ci: publish individual datapoints in metrics
8281d17 
Currently performance tests publish an aggregate of metrics over their
whole duration, like an average or a percentile.

This change: 1) allow publishing of "raw" datapoints, so we can do
different aggregations and better understand the data, and 2) rework the
test_network_latency test to output them, since it is the simplest one.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
test: limit snapshot restore test to 16GB memory
3f23ae6 
It is enough to illustrate how snapshot time scales with increasing
guest memory.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
test: remove gitlint warning about regexes
d294346 
```
gitlint will be switching from using Python regex 'match' (match
beginning) to 'search' (match anywhere) semantics.
```

Fix regex and opt-in into the new regex style.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o closed this Jun 28, 2023
@pb8o pb8o deleted the cleanups-3 branch June 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypat roypat roypat left review comments

Assignees

@pb8o pb8o

Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled python Pull requests that update Python code Status: Awaiting author Indicates that an issue or pull request requires author action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pb8o @roypat