quic: further optimize packet number parser #3329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all valid QUIC v1 packets, there are at least 16 bytes after the packet number field. (The AES-GCM MAC tag) Thus, we can use a trailing read to make fd_quic_pktnum_decode branchless.
ripatel-fd
force-pushed
the
ripatel/quic-pktnum-decode-opt
branch
from
4c86939
to
52f9c92
Compare
ptaffet-jump
reviewed
Nov 6, 2024
two-heart
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all valid QUIC v1 packets, there are at least 16 bytes after
the packet number field. (The AES-GCM MAC tag)
Thus, we can use a trailing read to make fd_quic_pktnum_decode
branchless.