Add tests for the gzip functionality - VM #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
=========================================
+ Coverage 83.24% 83.35% +0.1%
=========================================
Files 178 178
Lines 12022 12033 +11
Branches 2952 2958 +6
=========================================
+ Hits 10008 10030 +22
+ Misses 1837 1828 -9
+ Partials 177 175 -2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
=========================================
+ Coverage 83.24% 83.35% +0.1%
=========================================
Files 178 178
Lines 12022 12033 +11
Branches 2952 2958 +6
=========================================
+ Hits 10008 10030 +22
+ Misses 1837 1828 -9
+ Partials 177 175 -2
Continue to review full report at Codecov.
|
julienw
commented
Feb 6, 2019
| @@ -30,7 +30,7 @@ function workerOnMessage(zeeWorker: Worker) { | |||
| export function compress( | |||
| data: string | Uint8Array, | |||
| compressionLevel?: number | |||
| ): Promise<string> { | |||
| ): Promise<Uint8Array> { | |||
julienw
commented
Feb 6, 2019
| it('compresses and decompresses properly', async () => { | ||
| const clearText = '42'; | ||
| const gzipedData = await compress(clearText); | ||
| expect(gzipedData.constructor.name).toBe('Uint8Array'); |
There was a problem hiding this comment.
The Uint8Array's instance used is the one from inside the sandbox, that's why we can't use toBeInstanceOflike the other PR.
gregtatum
changed the title
gregtatum
approved these changes
Feb 8, 2019
|
closing in favor of #1731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we fake a worker by using node's VM capability. This isn't a real worker so it may have slightly different semantics (especially the structured clone algorithm) but it might be good enough for our needs.
Please compare with #1731.