Work around a change in the worker_threads module #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=========================================
- Coverage 84.3% 84.3% -0.01%
=========================================
Files 181 181
Lines 12610 12602 -8
Branches 3119 3117 -2
=========================================
- Hits 10631 10624 -7
+ Misses 1798 1797 -1
Partials 181 181
Continue to review full report at Codecov.
|
julienw
force-pushed
the
handle-worker-api-differences
branch
from
c6d61f0
to
d0d57a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1879
I ran the test with node v10, node v11.10 and node v11.12.