-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plcaes tab - use different colour for the individual's own events #4999
Conversation
change the color of the icon on map for birth and christening of the selected individuum to red.
change the color of the icon on map for birth and christening of the selected individuum to red.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
============================================
- Coverage 33.85% 33.85% -0.01%
- Complexity 11399 11400 +1
============================================
Files 1178 1178
Lines 47558 47561 +3
============================================
Hits 16103 16103
- Misses 31455 31458 +3 ☔ View full report in Codecov by Sentry. |
change the color of the icon on map for birth and christening of the selected individuum to red. blank char line 154 after closing brace
change the color of the icon on map for birth and christening of the selected individuum to red. remove blank at end of line 154
hi Greg |
The code-check is complaining that you have Would this be a simpler approach? It makes it easy to modify all the icons for the individual. protected const OWN_ICONS = [
'INDI:BIRT' => ['color' => 'red', 'name' => 'baby-carriage fas'],
'INDI:CHR' => ['color' => 'red', 'name' => 'water fas'],
] + self::ICONS; $icons = $fact->record() === $indi ? static::OWN_ICONS : static::ICONS; 'icon' => $icons[$fact->tag()] ?? static::DEFAULT_ICON, |
with Gregs modifications
what to do to handle the remaining unsuccessful check? |
How to handle: |
You can ignore this. It says that there are no tests that use these lines of the code. But none of this module has any tests yet. |
Thanks! |
change the color of the icon on map for birth and christening of the selected individuum to red.