Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken instance var from administrate #14

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

Mrjaco12
Copy link
Contributor

@Mrjaco12 Mrjaco12 commented Jun 6, 2018

Why:

  • Administrate broke the @_dashboard var
  • Want to use rails 5.2

This change addresses the need by:

  • Moving to @dashboard
  • Bumping dep version

Why:

* Adminisrate broke the `@_dashboard` var

This change addresses the need by:

* Moving to `@dashboard`
@lhoBas
Copy link

lhoBas commented Jul 23, 2018

@klaseskilson I've verified that this fix works, indeed necessary with more recent Administrate versions.

@klaseskilson
Copy link
Contributor

Cool. Sorry I haven't looked at this before. Completely missed it from my notification list. Thanks for your help @Mrjaco12 and @lhoBas.

@klaseskilson klaseskilson merged commit 322d736 into fishbrain:master Jul 23, 2018
@lhoBas
Copy link

lhoBas commented Jul 23, 2018

Awesome, thanks @klaseskilson - would you mind cutting a release?

@klaseskilson
Copy link
Contributor

Sure, will release!

@klaseskilson
Copy link
Contributor

v0.5.0 should now be available both here and on Rubygems. https://github.com/fishbrain/administrate-field-belongs_to_search/releases/tag/v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants