feat: added "serde" feature flag for bones_ecs #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added cfg_attr to Entities and BitSetVec so Entities can be serialized
…an pick the version
MaxCWhitehead
approved these changes
Aug 16, 2024
RockasMockas
pushed a commit
to RockasMockas/bones
that referenced
this pull request
Sep 9, 2024
There were existing of `#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]` lines already (f.e. on Entity struct), but serde feature flag itself was missing from bones_ecs. Also added `cfg_attr(feature = "serde") ...` line to Entities and BitSetVec so Entities struct can be serialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were existing of
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]lines already (f.e. on Entity struct), but serde feature flag itself was missing from bones_ecs.Also added
cfg_attr(feature = "serde") ...line to Entities and BitSetVec so Entities struct can be serialized.