fix: Comment out tests relating to component iteration until figure out why miri hangs on it #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut why miri hangs on it
|
am realizing some them don't hang locally, just take a long time, will revise. |
|
first run passed with all these commented out after 40min, will incrementally push back in what I can verify locally until find a smoking gun (or find nothing, heh) |
|
Restored some tests I had pass locally and it timed out again on CI here. Going to bump nightly version locally and see if can repro, but probably not an issue with tests, but regression in miri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue: #466
Possibly an issue with #454 ?
All of these tests are hanging in miri locally - will see if CI completes now.