This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Fixes #177 -- let the kernel build process drive cargo #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
kbuild-drives-minimal
branch
6 times, most recently
from
cc0a2c5
to
eb2af6f
Compare
geofft
approved these changes
Sep 15, 2019
hello-world/Makefile
Outdated
| obj-m := helloworld.o | ||
| helloworld-objs := hello_world.rust.o | ||
| KDIR ?= /lib/modules/$(shell uname -r)/build | ||
|
|
||
| $(src)/target/x86_64-linux-kernel/debug/libhello_world.a: $(src)/Cargo.toml $(wildcard $(src)/src/*.c) |
There was a problem hiding this comment.
If I'm reading Documentation/kbuild/makefiles.rst right, the target side of this should be $(obj), but I guess that involves setting CARGO_TARGET_DIR and some other things (cf. rust-lang/cargo#1657). Doesn't need to be done now but we should do it at some point.
| @@ -9,3 +9,4 @@ Module.symvers | |||
| *.mod.c | |||
| *.o | |||
| modules.order | |||
| dummy.c | |||
There was a problem hiding this comment.
Wait, why does this move? We're still doing a make -C kernel-cflags-finder, no?
There was a problem hiding this comment.
I had a dummy.c somewhere I didn't expect it. It's possible it came from some random intermediate debugging state.
alex
force-pushed
the
kbuild-drives-minimal
branch
2 times, most recently
from
4ce96f1
to
43105da
Compare
alex
force-pushed
the
kbuild-drives-minimal
branch
from
43105da
to
02b99ad
Compare
geofft
added a commit
that referenced
this pull request
Aug 9, 2020
This is #185 minus #188, but with the CONFIG_CC_IS_CLANG fix from #227. Co-authored-by: Geoffrey Thomas <[email protected]>
geofft
added a commit
that referenced
this pull request
Aug 11, 2020
The bulk of this is the changes from #185 that didn't make it into #188. We also upgrade Travis's Clang/LLVM version to 9 to pick up some sort of bugfix in relocation processing. With older versions, we get [ 1827.072410] module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 1, loc 00000000197e607d, val ffffffffc0703520 (where that "loc" seems to be random/garbage data, disconcertingly). Clang 9 is already required by kernels 5.0+ so this shouldn't be too much of a problem. Co-authored-by: Alex Gaynor <[email protected]>
geofft
added a commit
that referenced
this pull request
Aug 11, 2020
The bulk of this is the changes from #185 that didn't make it into #188. We also upgrade Travis's Clang/LLVM version to 9 to pick up some sort of bugfix in relocation processing. With older versions, we get [ 1827.072410] module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 1, loc 00000000197e607d, val ffffffffc0703520 (where that "loc" seems to be random/garbage data, disconcertingly). Clang 9 is already required by kernels 5.0+ so this shouldn't be too much of a problem. Co-authored-by: Alex Gaynor <[email protected]>
geofft
added a commit
that referenced
this pull request
Aug 11, 2020
The bulk of this is the changes from #185 that didn't make it into #188. We also upgrade Travis's Clang/LLVM version to 9 to pick up some sort of bugfix in relocation processing. With older versions, we get [ 1827.072410] module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 1, loc 00000000197e607d, val ffffffffc0703520 (where that "loc" seems to be random/garbage data, disconcertingly). Clang 9 is already required by kernels 5.0+ so this shouldn't be too much of a problem. Co-authored-by: Alex Gaynor <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more minimal version of #185. Doesn't have all of the benefits, but does work in more cases I believe!