update react peerDependencies to support React 18 (#503)

* chore: update react peerDependencies to support React 18 * fix: fix keydown scroll in React 18 Co-authored-by: Alex Drimbe <[email protected]>
fisshy · Apr 1, 2022 · 2c2a47d · 2c2a47d
1 parent ce17777
commit 2c2a47d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/examples/basic-keydown/app.js b/examples/basic-keydown/app.js
@@ -49,7 +49,11 @@ class Section extends React.Component{
           <div className="container-fluid">
             <div className="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
               <ul className="nav navbar-nav">
-                <li>  <input onKeyDown={e => {() => console.log("keydown"), scroll.scrollMore(500) }}/>
+                <li>  <input onKeyDown={e => {
+                    console.log("keydown");
+                    scroll.scrollMore(500);
+                    e.stopPropagation();
+                }}/>
                   <a onClick={() => scroll.scrollTo(100)}>Scroll To 100!</a>
                 </li>
               </ul>

diff --git a/modules/__tests__/scroll-cancellation-test.js b/modules/__tests__/scroll-cancellation-test.js
@@ -23,8 +23,9 @@ describe('Scroll cancelation', () => {
       const distance = 100;
 
       class TestComponent extends React.Component {
-        handleKeyDown = () => {
+        handleKeyDown = (e) => {
           scroll.scrollMore(distance, { smooth: true, duration });
+          e.stopPropagation();
         }
         render() {
           return (
@@ -65,8 +66,9 @@ describe('Scroll cancelation', () => {
       const distance = 100;
 
       class TestComponent extends React.Component {
-        handleKeyDown = () => {
+        handleKeyDown = (e) => {
           scroll.scrollMore(distance, { smooth: true, duration, horizontal: true });
+          e.stopPropagation();
         }
         render() {
           return (

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -66,8 +66,8 @@
     "webpack-dev-server": "^2.11.5"
   },
   "peerDependencies": {
-    "react": "^15.5.4 || ^16.0.0 || ^17.0.0",
-    "react-dom": "^15.5.4 || ^16.0.0 || ^17.0.0"
+    "react": "^15.5.4 || ^16.0.0 || ^17.0.0 || ^18.0.0",
+    "react-dom": "^15.5.4 || ^16.0.0 || ^17.0.0 || ^18.0.0"
   },
   "babel": {
     "presets": [