Skip to content
This repository has been archived by the owner on Mar 2, 2021. It is now read-only.

Rework DOM updates, to direct JS calls #146

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dignifiedquire
Copy link

@dignifiedquire dignifiedquire commented Apr 13, 2020

Original Motivation: Make it easier to implement Dom Refs.
Follow on Motivation: Less Javascript in your source files ;)

In light of #77 (comment) I reworked the way DOM updates are sent. Instead of copying the changes in an OP list to JS land, this calls bindings through web-sys directly.

Perf:

As far as I have measured very similar to master. Tested both current Firefox and Chrome.

Non scientific screenshots of running the triangle example

master

Screenshot 2020-04-14 at 00 25 56

x-direct

Screenshot 2020-04-14 at 00 23 38

Missing:

  • 1 test is failing, could use some pointers as to why. For some reason the new version adds the event attributes, but they are not expected to be there in the js test
  • some small TODOs on setting attributes
  • more testing?

@extraymond extraymond mentioned this pull request May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant