Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract URL Parameter Macro Update #54

Merged
merged 4 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/auto-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: 'auto release'
on:
pull_request:
types:
- closed
branches:
- main

jobs:
call-workflow-passing-data:
if: github.event.pull_request.merged
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
secrets: inherit
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

env/
target/
dbt_modules/
logs/
env/
dbt_packages/
dbt_packages/
package-lock.yml
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# dbt_google_ads_source v0.10.1

[PR #54](https://github.com/fivetran/dbt_google_ads_source/pull/54) includes the following updates:
## Bug Fixes
- This package now leverages the new `google_ads_extract_url_parameter()` macro for use in parsing out url parameters. This was added to create special logic for Databricks instances not supported by `dbt_utils.get_url_parameter()`.
- This macro will be replaced with the `fivetran_utils.extract_url_parameter()` macro in the next breaking change of this package.

## Under the Hood
- Included auto-releaser GitHub Actions workflow to automate future releases.

# dbt_google_ads_source v0.10.0

[PR #43](https://github.com/fivetran/dbt_google_ads_source/pull/43) includes the following updates:
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads_source'
version: '0.10.0'
version: '0.10.1'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
vars:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'google_ads_source_integration_tests'
version: '0.10.0'
version: '0.10.1'
profile: 'integration_tests'
config-version: 2

Expand Down
20 changes: 20 additions & 0 deletions macros/google_ads_extract_url_parameters.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{% macro google_ads_extract_url_parameter(field, url_parameter) -%}

{{ return(adapter.dispatch('google_ads_extract_url_parameter', 'google_ads_source') (field, url_parameter)) }}

{% endmacro %}


{% macro default__google_ads_extract_url_parameter(field, url_parameter) -%}

{{ dbt_utils.get_url_parameter(field, url_parameter) }}

{%- endmacro %}


{% macro spark__google_ads_extract_url_parameter(field, url_parameter) -%}

{%- set formatted_url_parameter = "'" + url_parameter + "=([^&]+)'" -%}
nullif(regexp_extract({{ field }}, {{ formatted_url_parameter }}, 1), '')

{%- endmacro %}
10 changes: 5 additions & 5 deletions models/stg_google_ads__ad_history.sql
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ url_fields as (
{{ dbt.split_part('final_url', "'?'", 1) }} as base_url,
{{ dbt_utils.get_url_host('final_url') }} as url_host,
'/' || {{ dbt_utils.get_url_path('final_url') }} as url_path,
{{ dbt_utils.get_url_parameter('final_url', 'utm_source') }} as utm_source,
{{ dbt_utils.get_url_parameter('final_url', 'utm_medium') }} as utm_medium,
{{ dbt_utils.get_url_parameter('final_url', 'utm_campaign') }} as utm_campaign,
{{ dbt_utils.get_url_parameter('final_url', 'utm_content') }} as utm_content,
{{ dbt_utils.get_url_parameter('final_url', 'utm_term') }} as utm_term
{{ google_ads_source.google_ads_extract_url_parameter('final_url', 'utm_source') }} as utm_source,
{{ google_ads_source.google_ads_extract_url_parameter('final_url', 'utm_medium') }} as utm_medium,
{{ google_ads_source.google_ads_extract_url_parameter('final_url', 'utm_campaign') }} as utm_campaign,
{{ google_ads_source.google_ads_extract_url_parameter('final_url', 'utm_content') }} as utm_content,
{{ google_ads_source.google_ads_extract_url_parameter('final_url', 'utm_term') }} as utm_term
from final_urls
)

Expand Down