Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update to use fivetran_utils.extract_url_parameter instead of dbt_utils.get_url_parameter #29

Open
1 task done
fivetran-catfritz opened this issue Nov 27, 2023 · 1 comment
Labels
issue:copycat priority:p4 Affects few users; pick up when available status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-catfritz
Copy link
Contributor

Copied from fivetran/dbt_facebook_ads #37.

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

An issue with dbt_utils.get_url_parameter was discovered in fivetran/dbt_linkedin_source#55 for Databricks SQL. Macro fivetran_utils.extract_url_parameter was added to solve this issue for Databricks targets (see fivetran/dbt_fivetran_utils#130 more info).

For this package, references to dbt_utils.get_url_parameter need to be updated to fivetran_utils.extract_url_parameter.

@fivetran-catfritz fivetran-catfritz added issue:copycat priority:p4 Affects few users; pick up when available status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates labels Nov 27, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

The latest release of this package has been updated to use the custom microsoft_ads.extract_url_parameter() macro. This addresses the immediate issue raised in this feature request. However, in the next breaking change of this package we will want to remove the custom macro and swap the package to leverage the fivetran_utils.extract_url_parameter() macro.

This was not implemented originally as it could possibly have caused breaking changes, we wanted to address the issue in a timely manner while ensuring we did not break any transformation pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:copycat priority:p4 Affects few users; pick up when available status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

2 participants