Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract URL Parameter Macro Update #30

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Extract URL Parameter Macro Update #30

merged 4 commits into from
Dec 14, 2023

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Dec 11, 2023 •
edited
Loading

This pull request was created automatically 🎉 and addresses Issue #29:

  • Ensure the .github/workflows/auto-release.yml has been properly added.
  • Ensure all references of dbt_utils.get_url_parameters has been updated to reflect the newly created package macro.
  • Update the package version (currently vX.X.UPDATE) in the CHANGELOG.
  • Update project versions in the dbt_project.yml and integration_tests/dbt_project.yml files.
  • Confirm BuildKite is passing.
  • Docs have been regenerated (to be generated following approval).

fivetran-jamie
fivetran-jamie approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 8930ed6 into main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fivetran-jamie fivetran-jamie fivetran-jamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivetran-joemarkiewicz @fivetran-jamie