-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz these changes look great. However, I am curious why we are seeing a number of the sources in the integration tests are not being found? Do you know why that may be? I would assume that these should be found.
…an/dbt_microsoft_ads into MagicBot/add-union-schema merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates! These look good to go with a small request to update the CHANGELOG and README.
Once those final updates are applied then this will be good to ship once the others are ready.
Issue: #27
Confirm the following files were correctly updated automatically:
window functions (partition by)Manual updates:
source_relation
to downstream models if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
dbt run
locally passesdbt test
locally passes