Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #28

Merged
merged 14 commits into from
Oct 12, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Sep 1, 2023

Issue: #27

Confirm the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • stg_microsoft_ads.yml, src_microsoft_ads.yml, microsoft_ads.yml (depending if source or transform)
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added in staging and transform models
  • tests

Manual updates:

  • Add source_relation to downstream models if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • dbt run locally passes
  • dbt test locally passes

@fivetran-catfritz fivetran-catfritz linked an issue Sep 1, 2023 that may be closed by this pull request
4 tasks
@fivetran-catfritz fivetran-catfritz self-assigned this Sep 1, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz these changes look great. However, I am curious why we are seeing a number of the sources in the integration tests are not being found? Do you know why that may be? I would assume that these should be found.

image

packages.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates! These look good to go with a small request to update the CHANGELOG and README.

Once those final updates are applied then this will be good to ship once the others are ready.

CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-catfritz fivetran-catfritz merged commit 4a87f2c into main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add union schema capability
2 participants