-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #29
Conversation
Note--we need to decide if we update identifiers for It technically passes buildkite, but reviewing the logs, it can't find a lot of the seed tables because of the identifier issues, which would mean problems for others using identifiers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment in the CHANGELOG. Other than that, and the fivetran utils dep being updated. This will be good to go once all others are approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! These look good to go. I do have a small request for an update in the CHANGELOG and README.
Once those are applied this should be ready to ship once all the others are ready.
Merging for release on 12-Oct-2023. |
Issue: #28
Confirm the following files were correctly updated automatically:
joinsManual updates:
source_relation
to downstream models if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
dbt run
locally passesdbt test
locally passes