Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/keywords-variable-addition #25

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature: Ad Reporting Issue #77

This PR will result in the following new package version: v0.7.1

This will not be a breaking change as it is only including a new variable to allow users to disable the keyword reports. This will have no impact on existing users, but will allow users to configure their package more uniquely based on their source schema.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

This PR includes a new variable pinterest__using_keywords that allows users to disable the keywords reports within Pinterest if they are not needed or are not located within the users source schema.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (pinterest__using_keywords set to both true and false)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

This PR was validated by ensuring the keyword reports were not included in the run if the pinterest__using_keywords variable was defined as false. Similarly, this was tested inversely to ensure they were included if the variable was set to true or not defined at all (testing the default behavior).

  • Variable set to false

    • The keyword tables are not included
      image
  • Variable set to true

    • The keyword tables are included
      image
  • Variable not defined (default)

    • The keyword tables are included
      image

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • [n/a] DECISIONLOG updates have been updated (if applicable)
  • [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

📚

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Jun 6, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review June 6, 2023 21:34
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages.yml Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 648d6b5 into main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants