-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Passthrough Variable #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DylanBaker I made an update to the passthrough variable that I would like to get your eyes on. It seemed that within the stg_pinterest_ads__pin_promotion_report
model there may be instances where users would want to pass more than just a single field through (for example we have a default field coalesce(clickthrough_1,0) + coalesce(clickthrough_2,0) as clicks
and I assume users may want to do something similar).
As such, I added a bit more configurability to the passthrough variable so users my do just that. Does this update align with your understanding of how users use their Pinterest data? Or would there never be an instance when a user would want this and we should just stick with single field passthrough variable ability?
@fivetran-joemarkiewicz Given that they could always do the transformation at the other end of the package (given we just sum) I'd be inclined to leave it with the more simple implementation. They can always grab the ad adapter and add or divide things up at that point. Feels like the new syntax, while powerful, likely makes the implementation for the user a bit more complicated? |
Yeah that makes sense that the user could just grab the ad adapter and add or divide from there on their own. Thanks for giving a glance at this. I'll revert these changes to keep with simplicity and not over complicating the package. Thanks @DylanBaker! |
Are you a current Fivetran customer?
Dylan, Fivetran
What change(s) does this PR introduce?
Allows additional metrics to be defined and added as pass-through metrics.
Does this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?