Feature/cdm line item #17

fivetran-catfritz · 2024-06-26T22:21:14Z

PR Overview

This PR will address the following Issue/Feature:

Quarterly project

This PR will result in the following new package version:

v0.3.0 for new model

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Features

Introduced the new recharge__line_item_enhanced model. This model includes a line item enriched with invoice, subscription, payment, and refund information. This model has been built with the intention of retaining a common line item schema across all other Fivetran billing data models.

🚨 Breaking Changes 🚨

In the dbt_recharge_source v0.3.0 release, the following columns were added to model stg_recharge__address:

country

payment_method_id

❗Note: If you have already added any of these fields as passthrough columns to the recharge__address_passthrough_columns var, you will need to remove or alias these fields from the var to avoid duplicate column errors. Refer to the source package's release notes for more details.

Additional source package updates (release notes)

Added staging model stg_recharge__checkout. See this doc for the fields added and their definitions.

This model is disabled by default but can be enabled by setting variable recharge__checkout_enabled to true in your dbt_project.yml file. See the Enable/disable models and sources section of the README for more information.

This model can also be passed additional columns beyond the predefined columns by using the variable recharge__checkout_passthrough_columns. See the Passing Through Additional Columns section of the README for more information on how to set this variable.

Added the following columns to model stg_recharge__customer. See this doc for field definitions.

billing_first_name

billing_last_name

billing_company

billing_city

billing_country

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

dbt run –full-refresh && dbt test
~~dbt run (if incremental models are present) && dbt test~~

Before marking this PR as "ready for review" the following have been applied:

~~The appropriate issue has been linked, tagged, and properly assigned~~
All necessary documentation and version upgrades have been applied
docs were regenerated (unless this PR does not include any code or yml updates)
BuildKite integration tests are passing
Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

See internal ticket for schema sample.

If you had to summarize this PR in an emoji, which would it be?

💃

models/common data models/recharge__line_item_enhanced.sql

fivetran-joemarkiewicz

@fivetran-catfritz great work on this PR! I just a have a few requested changes before this is ready for full approval! Thanks again 😃

README.md

integration_tests/seeds/checkout_data.csv

models/common data models/recharge__line_item_enhanced.sql

CHANGELOG.md

fivetran-catfritz

@fivetran-joemarkiewicz Thanks for the comments! This is ready for re-review. I added as much documentation as I could minus the field definitions we will add later.

integration_tests/seeds/checkout_data.csv

models/common data models/recharge__line_item_enhanced.sql

CHANGELOG.md

README.md

fivetran-joemarkiewicz

@fivetran-catfritz thanks for these most recent changes! This is looking great and real close but I have just a few questions before approval.

CHANGELOG.md

README.md

models/common_data_models/docs.md

fivetran-joemarkiewicz · 2024-07-09T19:08:42Z

models/common_data_models/recharge__common_data_models.yml

+      - dbt_utils.unique_combination_of_columns:
+          combination_of_columns:
+            - header_id
+            - line_item_index


Be sure to include the source_relation field here. I missed this originally but you will need to include that field in this test and also in all the joins within the new model.

Recharge is not yet a member of the union data club. 😄

It's not cool yet haha then nevermind, disregard my comment lol

fivetran-joemarkiewicz · 2024-07-09T19:37:46Z

integration_tests/seeds/checkout_data.csv

For some reason I keep getting this failure when trying to run this using the seed data and having the using checkout variable enabled as true. Any ideas?

Ahh I needed to update the dbt_project.yml with the seed column type to match what I did in the source.

fivetran-catfritz

@fivetran-joemarkiewicz Thanks for the comments! I made the necessary updates and have one more question about the docs. Thanks!

CHANGELOG.md

fivetran-catfritz · 2024-07-09T20:15:36Z

integration_tests/seeds/checkout_data.csv

Ahh I needed to update the dbt_project.yml with the seed column type to match what I did in the source.

models/common_data_models/docs.md

fivetran-catfritz · 2024-07-09T20:28:06Z

models/common_data_models/recharge__common_data_models.yml

+      - dbt_utils.unique_combination_of_columns:
+          combination_of_columns:
+            - header_id
+            - line_item_index


Recharge is not yet a member of the union data club. 😄

fivetran-catfritz

@fivetran-joemarkiewicz I have updated the doc yml and generated the dbt docs!

packages.yml

fivetran-joemarkiewicz

LGTM!

fivetran-catfritz

Agree with selection for customer_created_at and subscription_plan.

fivetran-reneeli

looks good!

fivetran-catfritz added 6 commits June 24, 2024 21:05

feature/cdm-line-item

bb46d5b

updates

a5897de

update after validation

6c1c3e1

bump versions

d4f080f

bump versions

8d4c185

update changelog

1a84650

fivetran-catfritz requested a review from fivetran-joemarkiewicz June 26, 2024 22:33

fivetran-catfritz self-assigned this Jun 26, 2024

fivetran-catfritz commented Jun 27, 2024

View reviewed changes

models/common data models/recharge__line_item_enhanced.sql Outdated Show resolved Hide resolved

small update

1522c48

fivetran-catfritz changed the base branch from main to release/v0.3.0 June 27, 2024 17:00

fivetran-joemarkiewicz requested changes Jun 28, 2024

View reviewed changes

fivetran-catfritz added 4 commits July 9, 2024 12:58

update changelog & readme

4bbddb9

add dummy docs

ec2eead

add dummy docs

2d2a4ef

add dummy docs

e891278

fivetran-catfritz commented Jul 9, 2024

View reviewed changes

fivetran-joemarkiewicz requested changes Jul 9, 2024

View reviewed changes

fivetran-catfritz added 2 commits July 9, 2024 15:09

update readme

5bef9ad

update docs and changelog

9f840b0

fivetran-catfritz commented Jul 9, 2024

View reviewed changes

fivetran-catfritz added 2 commits July 9, 2024 16:14

add defitions and generate docs

18e2d34

remove docs.md

02c38ff

fivetran-catfritz commented Jul 9, 2024

View reviewed changes

packages.yml Outdated Show resolved Hide resolved

fivetran-catfritz requested a review from fivetran-joemarkiewicz July 9, 2024 21:24

fivetran-joemarkiewicz approved these changes Jul 9, 2024

View reviewed changes

fivetran-joemarkiewicz added 2 commits August 5, 2024 19:28

final updates before release

435a058

variable addition

2fb4ff0

fivetran-joemarkiewicz changed the base branch from release/v0.3.0 to main August 6, 2024 05:44

Update README.md

4d090ad

fivetran-catfritz commented Aug 12, 2024

View reviewed changes

fivetran-catfritz added 2 commits August 12, 2024 17:22

update readme, changelog, regen docs

11839d8

update changelog

0fa97c7

fivetran-reneeli approved these changes Aug 13, 2024

View reviewed changes

Update packages.yml

32df872

fivetran-catfritz merged commit e9e85ff into main Aug 14, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/cdm line item #17

Feature/cdm line item #17

fivetran-catfritz commented Jun 26, 2024 •

edited

Loading

fivetran-joemarkiewicz left a comment

fivetran-catfritz left a comment

fivetran-joemarkiewicz left a comment

fivetran-joemarkiewicz Jul 9, 2024

fivetran-catfritz Jul 9, 2024

fivetran-joemarkiewicz Jul 9, 2024

fivetran-joemarkiewicz Jul 9, 2024

fivetran-catfritz Jul 9, 2024

fivetran-catfritz left a comment

fivetran-catfritz Jul 9, 2024

fivetran-catfritz Jul 9, 2024

fivetran-catfritz left a comment

fivetran-joemarkiewicz left a comment

fivetran-catfritz left a comment

fivetran-reneeli left a comment

Feature/cdm line item #17

Feature/cdm line item #17

Conversation

fivetran-catfritz commented Jun 26, 2024 • edited Loading

PR Overview

Features

🚨 Breaking Changes 🚨

Additional source package updates (release notes)

PR Checklist

Basic Validation

Detailed Validation

If you had to summarize this PR in an emoji, which would it be?

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

fivetran-catfritz left a comment

Choose a reason for hiding this comment

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

fivetran-joemarkiewicz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-catfritz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-joemarkiewicz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-joemarkiewicz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-catfritz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-catfritz left a comment

Choose a reason for hiding this comment

fivetran-catfritz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-catfritz Jul 9, 2024

Choose a reason for hiding this comment

fivetran-catfritz left a comment

Choose a reason for hiding this comment

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

fivetran-catfritz left a comment

Choose a reason for hiding this comment

fivetran-reneeli left a comment

Choose a reason for hiding this comment

fivetran-catfritz commented Jun 26, 2024 •

edited

Loading