-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add line item standardized model #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for working through this update! I have a few comments, questions, and suggestions below. Let me know if you would like to sync in more detail regarding any of my comments.
Thanks!
integration_tests/tests/integrity/integrity_line_item_enhanced.sql
Outdated
Show resolved
Hide resolved
integration_tests/tests/consistency/consistency_line_item_enhanced.sql
Outdated
Show resolved
Hide resolved
integration_tests/tests/integrity/integrity_line_item_enhanced.sql
Outdated
Show resolved
Hide resolved
integration_tests/tests/integrity/integrity_line_item_enhanced.sql
Outdated
Show resolved
Hide resolved
….com/fivetran/dbt_shopify into feature/standardized-line-item-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for addressing my comments! I have a few additional notes I would like you to address below. Additionally, please add a CHANGELOG entry for this update. Once those are addressed this should be good to go!
integration_tests/tests/integrity/integrity_line_item_enhanced.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @fivetran-reneeli thanks for working through all my review notes. Please regen the docs and then this will be good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
The appropriate issue has been linked, tagged, and properly assignedDetailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
🧥