Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unstructured data #53

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Aug 16, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • 0.12.0 for addition of new columns

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking changes

  • Added field _fivetran_deleted to the following models for use downstream:
    • stg_zendesk__ticket
    • stg_zendesk__ticket_comment
    • stg_zendesk__user

Documentation

  • Updated documentation to include _fivetran_deleted.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • simple column addition

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-catfritz fivetran-catfritz self-assigned this Aug 16, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz thanks for this update! I have one small comment. Let me know if you have questions and when the updates are applied.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Thanks for reviewing! I have updated the changelog.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @fivetran-catfritz before we merge this, can you also incorporate PR #54 into this one so we can batch these changes in one release?

@fivetran-catfritz
Copy link
Contributor Author

The doc updates from #54 are merged.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Renee Li <[email protected]>
@fivetran-catfritz fivetran-catfritz merged commit fd7ffca into main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants