Update pip dependencies #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maringuu
requested changes
Nov 10, 2022
There was a problem hiding this comment.
The following modules did increase their major version:
- crpytography
- docker
- pytest-cov
- bcrypt
- flask_restx
- flask-security-too
- flask_sqlalchemy
- more_itertools
- cstruct
Its alot but did you read the changelogs?
Theoretically backwards incompatible changes that dont have test coverage by our tests could have been made.
jstucke
added a commit
that referenced
this pull request
Nov 14, 2022
OMG the tests were dependent on another and wouldn't work when executed individually. Who wrote this? 🤬
and removed one useless test
maringuu
force-pushed
the
update_pip_dependencies
branch
from
b007039
to
ec6995a
Compare
maringuu
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since flask-restx finally released the new version which is compatible with Flask 2.2.x, we can update our frontend dependencies.
I also updated all the other dependencies where possible and fixed resulting problems (mostly tests).