Fix for Issue #1413 #179
Merged
Fix for Issue #1413 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawosm-arm
reviewed
Apr 21, 2024
|
|
||
| TLI_DEFINE_VECFUNC("__rs_exp_1", "__rs_exp_4", FIXED(4)) | ||
| TLI_DEFINE_VECFUNC("__rs_exp_1", "__rs_exp_8", FIXED(8)) | ||
|
|
There was a problem hiding this comment.
nit: exta empty line not needed
There was a problem hiding this comment.
addressed this.
There was a problem hiding this comment.
ping @bryanpkc
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
shivaramaarao
force-pushed
the
shivaram_fix1413
branch
from
46facfb
to
6214c2d
Compare
pawosm-arm
approved these changes
Apr 22, 2024
|
@shivaramaarao could you consider cherry picking this to the |
bryanpkc
reviewed
May 15, 2024
| @@ -276,6 +277,10 @@ static TargetLibraryInfoImpl *createTLII(llvm::Triple &TargetTriple, | |||
| case CodeGenOptions::PGMATH: | |||
| TLII->addVectorizableFunctionsFromVecLib(TargetLibraryInfoImpl::PGMATH, | |||
| TargetTriple); | |||
| if (std::find(TargetOpts.Features.begin(), TargetOpts.Features.end(), "+avx512f") != TargetOpts.Features.end()) { | |||
| TLII->addVectorizableFunctionsFromVecLib(TargetLibraryInfoImpl::PGMATH_AVX512, | |||
| TargetTriple); | |||
There was a problem hiding this comment.
Can you run clang-format on this diff?
bryanpkc
reviewed
May 15, 2024
| @@ -584,7 +589,7 @@ bool EmitAssemblyHelper::AddEmitPasses(legacy::PassManager &CodeGenPasses, | |||
| raw_pwrite_stream *DwoOS) { | |||
| // Add LibraryInfo. | |||
| std::unique_ptr<TargetLibraryInfoImpl> TLII( | |||
| createTLII(TargetTriple, CodeGenOpts)); | |||
| createTLII(TargetTriple, CodeGenOpts,TargetOpts)); | |||
bryanpkc
reviewed
May 15, 2024
|
|
||
| TLI_DEFINE_VECFUNC("__rd_cosh_1", "__rd_cosh_2", FIXED(2)) | ||
| TLI_DEFINE_VECFUNC("__rd_cosh_1", "__rd_cosh_4", FIXED(4)) | ||
| TLI_DEFINE_VECFUNC("__rd_cosh_1", "__rd_cosh_8", FIXED(8)) | ||
|
|
There was a problem hiding this comment.
Unnecessary and inconsistent blank line.
|
Could you also please add a test case? |
This was referenced Jul 26, 2024
Closed
bryanpkc
reviewed
Jul 29, 2024
| TLI_DEFINE_VECFUNC("__fs_pow_1", "__fs_pow_16", FIXED(16)) | ||
| TLI_DEFINE_VECFUNC("__pd_pow_1", "__pd_pow_8", FIXED(8)) | ||
| TLI_DEFINE_VECFUNC("__ps_pow_1", "__ps_pow_16", FIXED(16)) | ||
| TLI_DEFINE_VECFUNC("__rd_pow_1", "__rd_pow_8", FIXED(8)) |
There was a problem hiding this comment.
__rs_pow_1 is missing here.
bryanpkc
reviewed
Jul 29, 2024
| TLI_DEFINE_VECFUNC("__ps_pow_1", "__ps_pow_16", FIXED(16)) | ||
| TLI_DEFINE_VECFUNC("__rd_pow_1", "__rd_pow_8", FIXED(8)) | ||
| TLI_DEFINE_VECFUNC("__fs_powi_1", "__fs_powi_16", FIXED(16)) | ||
|
|
There was a problem hiding this comment.
Incorrect grouping of lines.
bryanpkc
reviewed
Jul 29, 2024
| TLI_DEFINE_VECFUNC("__rd_log_1", "__rd_log_8", FIXED(8)) | ||
| TLI_DEFINE_VECFUNC("__rs_log_1", "__rs_log_16", FIXED(16)) | ||
|
|
||
| TLI_DEFINE_VECFUNC("__fs_exp_1", "__fs_exp_16", FIXED(16)) |
There was a problem hiding this comment.
Why are __fd_exp_1 and __fd_exp_8 not supported?
bryanpkc
reviewed
Jul 29, 2024
| #include "llvm/Analysis/VecFuncs.def" | ||
| }; | ||
| addVectorizableFunctions(VecFuncs); | ||
|
|
shivaramaarao
added a commit
that referenced
this pull request
Aug 11, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
shivaramaarao
added a commit
that referenced
this pull request
Aug 12, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
shivaramaarao
added a commit
that referenced
this pull request
Aug 13, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 19, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 19, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 25, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Sep 26, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
to Huawei-CPLLab/classic-flang-llvm-project
that referenced
this pull request
Oct 2, 2024
…lang-compiler#185) PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
bryanpkc
pushed a commit
that referenced
this pull request
Oct 14, 2024
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGMATH has AVX512 runtime functions and can be executed only when the application is compiled in avx512 mode. The VecFuncs.def has no information about the TargetOptions and avx512 functions are selected even in avx2 mode. This issue is fixed by creating separate table for AVX512 functions and using them only when avx512 mode is specified.