Pull 2018-01-25T12-01 Recent NVIDIA Changes #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing a constant value to a function argument where we were expecting a descriptor, which leads to a seg fault. The constant is created in the front end "transform_call", where we are missing a case here, when there is no member descriptor, use SDSC instead.
This bug occurs when we have a contiguous pointer to an array section that is passed to an assumed-shape formal like in this example: integer, pointer, contiguous :: p(:,:) integer, pointer :: matrix(:,:,:) allocate(matrix(...)) p => matrix(:,:,n) call sub(p) The section descriptor that we create and pass in to the procedure has an lbase value that represents the distance from the start of the array to the start of the section that the pointer represents. When we pass in the address of the first element that p points to, that distance is included in the pointer. So combined with the lbase offset in the descriptor we end up indexing too far into the array (or past the end). To fix this we need to either adjust the descriptor or pass in the address of the array instead of the first element of the section. This fix does the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.