fix: templating of notifications for SMTP #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Sep 25, 2024
moshloop
reviewed
Sep 25, 2024
adityathebe
force-pushed
the
fix/html-msg-templating
branch
from
4d4ca0a
to
1dd14c8
Compare
adityathebe
commented
Sep 25, 2024
adityathebe
force-pushed
the
fix/html-msg-templating
branch
from
1dd14c8
to
273a6ec
Compare
|
@moshloop added tests for all templates. |
moshloop
reviewed
Sep 25, 2024
adityathebe
force-pushed
the
fix/html-msg-templating
branch
from
273a6ec
to
ba5bef7
Compare
adityathebe
force-pushed
the
fix/html-msg-templating
branch
from
ba5bef7
to
d32318c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1446
This happend for SMTP notifications.
We need to first template and then convert the markdown to HTML.
Else the
markdown -> HTMLconversion will break all the go templating logic.