Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dirty flag #1806

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Removed dirty flag #1806

merged 1 commit into from
Sep 18, 2023

Conversation

rbrtbnfgl
Copy link
Contributor

Description

Remove dirty flag from the command that generates the TAG

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

Signed-off-by: Roberto Bonafiglia <[email protected]>
@manuelbuil
Copy link
Collaborator

Is dirty flag adding dirty when it detects something in the git index?

@rbrtbnfgl
Copy link
Contributor Author

yes

@manuelbuil
Copy link
Collaborator

did you find out why was something in the git index and not merged?

@rbrtbnfgl
Copy link
Contributor Author

rbrtbnfgl commented Sep 18, 2023

we modify some files during the release. I don't know why we are getting the dirty flag now and not on the previous releases.

@rbrtbnfgl rbrtbnfgl merged commit ea28613 into flannel-io:master Sep 18, 2023
8 checks passed
@rbrtbnfgl rbrtbnfgl deleted the remove_dirty branch September 18, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants