Add extra check before acquiring lease #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
addExtraCheck
branch
from
da8d303
to
815169e
Compare
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
addExtraCheck
branch
from
815169e
to
c9e7738
Compare
thomasferrandiz
approved these changes
Apr 12, 2024
rbrtbnfgl
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain windows environments, the host network is not ready by the time we acquire the lease, which makes flannel crash. This PR makes an additional check before acquiring the lease, so that we are sure the network is ready by the time we try acquiring the lease.
Apart from that, the PR:
Todos
Release Note