Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node-public-ip annotation #1982

Merged
merged 1 commit into from
May 29, 2024

Conversation

rbrtbnfgl
Copy link
Contributor

Description

This change the behave added in #1948 to fix #1978
It adds two new annotation node-public-ip and node-public-ipv6 to use instead.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@@ -31,7 +31,7 @@ If you want to deploy `flannel` securely in a shared namespace or want more fine
Other options include [Kyverno](https://kyverno.io/policies/pod-security/) and [OPA Gatekeeper](https://github.com/open-policy-agent/gatekeeper).
# Annotations

* `flannel.alpha.coreos.com/public-ip`, `flannel.alpha.coreos.com/public-ipv6`: Define the used public IP of the node. If configured when Flannel starts it'll be used as the `public-ip` and `public-ipv6` flag.
* `flannel.alpha.coreos.com/node-public-ip`, `flannel.alpha.coreos.com/node-public-ipv6`: Define the used public IP of the node. If configured when Flannel starts it'll be used as the `public-ip` and `public-ipv6` flag.
Copy link
Collaborator

@manuelbuil manuelbuil May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • flannel.alpha.coreos.com/node-public-ip, flannel.alpha.coreos.com/node-public-ipv6: Optionally set by the user, it defines the IP of the node for pod communications. It will be used to select the local interface, e.g. for the vxlan vtep. Flanneld will, later, use it as value for flannel.alpha.coreos.com/public-ip and flannel.alpha.coreos.com/public-ipv6

  • flannel.alpha.coreos.com/public-ip, flannel.alpha.coreos.com/public-ipv6: Set by flanneld informs of the node IP chosen for pod communication. This value is used by the rest of nodes to find the destination IP for the node.

  • flannel.alpha.coreos.com/public-ip-overwrite, flannel.alpha.coreos.com/public-ipv6-overwrite optionally set by the user, defines the IP of the node that will be announced to the rest for pod communications, e.g. the vtep of vxlan. Unlike the node-public-ip annotation, the IP does not need to be part of a local interface as this value has no influence on the vtep creation, only on the announcement of the node IP for the rest of the nodes. This annotation should only be used if the node is behind a NAT. It can be automatically set to a nodes ExternalIP using the flannel-node-annotator.See also the "NAT" section in troubleshooting if UDP checksums seem corrupted. See also the "NAT" section in troubleshooting if UDP checksums seem corrupted.

Signed-off-by: Roberto Bonafiglia <[email protected]>
@rbrtbnfgl rbrtbnfgl merged commit 8a6570f into flannel-io:master May 29, 2024
8 checks passed
@rbrtbnfgl rbrtbnfgl deleted the public-node-ip branch May 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants