Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DashboardWidget and Widget Component class names mismatched #2103

Closed
Ralkage opened this issue Mar 30, 2020 · 0 comments · Fixed by #2164
Closed

DashboardWidget and Widget Component class names mismatched #2103

Ralkage opened this issue Mar 30, 2020 · 0 comments · Fixed by #2164

Comments

@Ralkage
Copy link
Contributor

Ralkage commented Mar 30, 2020

Bug Report

I was trying to develop a new widget for the Admin Dashboard page and noticed a few minutes ago that the following classes are mismatched:

https://github.com/flarum/core/blob/master/js/src/admin/components/Widget.js#L12 the class name should be" Widget" to match the file name and with https://github.com/flarum/core/blob/master/js/src/admin/components/DashboardWidget.js#L12 the class name should be "DashboardWidget" instead of "Widget".

Looks like this has been here since it's conception in Beta 8 🙈

They pretty much have the same code despite the class name differences in both JS and HTML class attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants