Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed excess Widget class in favor of DashboardWidget #2164

Merged
merged 1 commit into from
May 20, 2020
Merged

Removed excess Widget class in favor of DashboardWidget #2164

merged 1 commit into from
May 20, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

@askvortsov1 askvortsov1 commented May 12, 2020 •
edited by dsevillamartin
Loading

Fixes #2103
See #2144, #1821

Changes proposed in this pull request:

  • Removed excess, unused Widget class in favor of DashboardWidget

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@askvortsov1 askvortsov1 mentioned this pull request May 12, 2020
Closed
65 tasks
@askvortsov1 askvortsov1 linked an issue May 17, 2020 that may be closed by this pull request
DashboardWidget and Widget Component class names mismatched #2103
Closed
@askvortsov1 askvortsov1 merged commit acf4e9c into master May 20, 2020
@askvortsov1 askvortsov1 deleted the as/frontend-cleanup-widgets branch May 20, 2020 00:52
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone May 20, 2020
@franzliedke franzliedke removed this from the 0.1.0-beta.14 milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@dsevillamartin dsevillamartin dsevillamartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DashboardWidget and Widget Component class names mismatched
4 participants
@askvortsov1 @tankerkiller125 @dsevillamartin @franzliedke