Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Policy Refactor, Extender #2056

Closed
wants to merge 15 commits into from
Closed

WIP Policy Refactor, Extender #2056

wants to merge 15 commits into from

Commits on Mar 22, 2020

  1. Added new methods to AbstractPolicy, deprecated old ones

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    71c6fb8 View commit details
    Browse the repository at this point in the history

  2. Added extendable, singleton for policies, switched gate->before() and… 

    … scopeModelVisibility to use that singleton
    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    4138ffd View commit details
    Browse the repository at this point in the history

  3. Removed old system for subscribing to policies in the relevant servic… 

    …e provider
    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    303fdce View commit details
    Browse the repository at this point in the history

  4. Marked GetPermission as deprecated

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    8919bbf View commit details
    Browse the repository at this point in the history

  5. Removed no longer necessary GroupServiceProvider

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    e66fcc9 View commit details
    Browse the repository at this point in the history

  6. Renamed policy instances to scopeQuery

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    f57d0d6 View commit details
    Browse the repository at this point in the history

  7. Cleaned up scoping to re-separate scoping queries given an ability vs… 

    … just viewing instances in a query
    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    da1dec8 View commit details
    Browse the repository at this point in the history

  8. Added Policy extender

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6867299 View commit details
    Browse the repository at this point in the history

  9. Typo fix

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    c72ed74 View commit details
    Browse the repository at this point in the history

  10. Fixed incorrect doc block for policy extender

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    ade8de7 View commit details
    Browse the repository at this point in the history

  11. Fixed core policies to return ->allow() vs true

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    4de328c View commit details
    Browse the repository at this point in the history

  12. Removed unused import

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6dcbda2 View commit details
    Browse the repository at this point in the history

  13. Added test cases for policy extender

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    0271718 View commit details
    Browse the repository at this point in the history

  14. Updated policy test to use userId instead of isAdmin on authenticated… 

    … test case
    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    2aafb3b View commit details
    Browse the repository at this point in the history

  15. Updated tests to use BuildsHttpRequest trait

    @askvortsov1
    askvortsov1 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6078a0d View commit details
    Browse the repository at this point in the history