Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Discussion List State into its own class #2150

Merged
merged 35 commits into from
Jun 18, 2020
Merged

Move Discussion List State into its own class #2150

merged 35 commits into from
Jun 18, 2020
+230 −204

Commits on Jun 18, 2020

  1. Copied over David's changes from TS rewrite

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    76f14ca View commit details
    Browse the repository at this point in the history

  2. Don't create new instances of DiscussionListState; keep the same one … 

    …throughout and simply refresh its contents
    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    e10fc90 View commit details
    Browse the repository at this point in the history

  3. npm run format

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    059d6d3 View commit details
    Browse the repository at this point in the history

  4. Add discussionListState clear, hasDiscussions methods

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5233738 View commit details
    Browse the repository at this point in the history

  5. Remove check for discussionList existing, as it's now always instanti… 

    …ated
    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    9e16666 View commit details
    Browse the repository at this point in the history

  6. Removed unnecessary / incorrect comment

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4494d06 View commit details
    Browse the repository at this point in the history

  7. Moved DiscussionListState out of app.mount

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    62eb4a9 View commit details
    Browse the repository at this point in the history

  8. Prettify

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4960e9a View commit details
    Browse the repository at this point in the history

  9. Don't put discussionList in app.cache

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    cc2eefc View commit details
    Browse the repository at this point in the history

  10. Remove defensive coding

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    00e877c View commit details
    Browse the repository at this point in the history

  11. Better encapsulation of state's properties

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fa78193 View commit details
    Browse the repository at this point in the history

  12. Fix comment

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    1236b47 View commit details
    Browse the repository at this point in the history

  13. Add redraws to clear, removeDiscussion

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    906b53c View commit details
    Browse the repository at this point in the history

  14. Add redraw to addDiscussion

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    0dfaac9 View commit details
    Browse the repository at this point in the history

  15. Always refresh after setting discussion list params

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5f226bf View commit details
    Browse the repository at this point in the history

  16. Don't use a separate setParams method, refresh only.

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8e21b45 View commit details
    Browse the repository at this point in the history

  17. prettify

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    e55b53f View commit details
    Browse the repository at this point in the history

  18. Move loading out of conditional

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    df11674 View commit details
    Browse the repository at this point in the history

  19. Use clear method, trigger a redraw if clearing

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    6f566cc View commit details
    Browse the repository at this point in the history

  20. Fixed "no discussions" error being shown even if discussions are pres… 

    …ent. Not sure how that got in there...
    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fe41095 View commit details
    Browse the repository at this point in the history

  21. Dependency injection for of app into discusisonListState

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    71f5ae7 View commit details
    Browse the repository at this point in the history

  22. Avoid excess redraws

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    1b3744e View commit details
    Browse the repository at this point in the history

  23. Allow customization of discussion list component class

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    aa4ec8b View commit details
    Browse the repository at this point in the history

  24. Reorganize refresh signature to use options hash

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    7f1c5b8 View commit details
    Browse the repository at this point in the history

  25. Encapsulate whether a discussion list entails search results

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c886ec7 View commit details
    Browse the repository at this point in the history

  26. Remove unnecessary declaration (not TS yet)

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    2337fde View commit details
    Browse the repository at this point in the history

  27. Rename discussionList to discussions

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    1c2201f View commit details
    Browse the repository at this point in the history

  28. Add docblock to app.discussions

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    09d58c0 View commit details
    Browse the repository at this point in the history

  29. Go back to hardcoding use of discussion list class

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    0223c36 View commit details
    Browse the repository at this point in the history

  30. Fix missing word in comment

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    a904ca1 View commit details
    Browse the repository at this point in the history

  31. Cleanup complicated some

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    0ca5eba View commit details
    Browse the repository at this point in the history

  32. Clean up params and refresh logic

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    cf94103 View commit details
    Browse the repository at this point in the history

  33. Put clear back in

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c08bc2a View commit details
    Browse the repository at this point in the history

  34. Encapsulate empty state

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    eb15f01 View commit details
    Browse the repository at this point in the history

  35. Bugfix

    @askvortsov1
    askvortsov1 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    90616ef View commit details
    Browse the repository at this point in the history