Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checkbox switch component background stand out in modals #2443

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Make checkbox switch component background stand out in modals #2443

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5e0ac5
Make switch component background stand out in modals
nina-py Nov 7, 2020
7acecf0
Moved styles to Modal.less and changed target to .Modal-body
nina-py Nov 8, 2020
62af67b
Simplified styles as suggested
nina-py Nov 8, 2020
c4b0cae
Changed background from to
nina-py Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions less/common/Modal.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@
text-align: left;
}
}

.Checkbox--switch .Checkbox-display {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we use .off.Checkbox--switch .Checkbox-display here instead we could probably avoid having to declaring the block under it 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just gave it a go - it works, thanks for the suggestion!

background: @body-bg;
}

.on.Checkbox--switch .Checkbox-display {
background: #58a400;
}
}
.Modal-footer {
border: 0;
Expand Down