Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Filter Split, Use Same Controller #2454

Merged
merged 36 commits into from
Feb 24, 2021
Merged

Search Filter Split, Use Same Controller #2454

merged 36 commits into from
Feb 24, 2021

Commits on Feb 21, 2021

  1. Introduce extensible filterer system, make ListUsersController and Li… 

    …stDiscussionsController use that instead of searcher if a "q" filter parameter is provided
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    49f7c92 View commit details
    Browse the repository at this point in the history

  2. Add filter counterparts to builtin gambits

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    f76de0b View commit details
    Browse the repository at this point in the history

  3. Properly register filters, support negation (passed into filter inter… 

    …face)
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    7c99276 View commit details
    Browse the repository at this point in the history

  4. Add tests for all user filters and gambits

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8fd3f11 View commit details
    Browse the repository at this point in the history

  5. Fix created filter

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    34594fc View commit details
    Browse the repository at this point in the history

  6. Add tests for all discussion filters and gambits

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    619913c View commit details
    Browse the repository at this point in the history

  7. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    dd61e44 View commit details
    Browse the repository at this point in the history

  8. Fix failing tests

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    44e7431 View commit details
    Browse the repository at this point in the history

  9. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    f644c69 View commit details
    Browse the repository at this point in the history

  10. Add types

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    7b409cb View commit details
    Browse the repository at this point in the history

  11. Expect eloquent builder

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    e970282 View commit details
    Browse the repository at this point in the history

  12. Merge gambits into "FilterGambit"

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    6ccd7a5 View commit details
    Browse the repository at this point in the history

  13. Use Arr::get in CreatedFilterGambit

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    a8c9ae8 View commit details
    Browse the repository at this point in the history

  14. Inject filters and filter mutators instead of static

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    837253d View commit details
    Browse the repository at this point in the history

  15. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    60a1a2b View commit details
    Browse the repository at this point in the history

  16. Per-resource filter classes

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    94823ba View commit details
    Browse the repository at this point in the history

  17. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8703956 View commit details
    Browse the repository at this point in the history

  18. List controllers no longer need repositories

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    66976fc View commit details
    Browse the repository at this point in the history

  19. Add missing imports

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    6b96457 View commit details
    Browse the repository at this point in the history

  20. Move gambit pattern to method instead of attribute for consistency

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    6f27690 View commit details
    Browse the repository at this point in the history

  21. Combine search and filter criteria classes

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    2838f11 View commit details
    Browse the repository at this point in the history

  22. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    ad38f79 View commit details
    Browse the repository at this point in the history

  23. Use null coalesce instead of shorthand ternary

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    9fcc7cd View commit details
    Browse the repository at this point in the history

  24. Replace WrappedFilter and AbstractSearch with FilterState and SearchS… 

    …tate
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    70ebed2 View commit details
    Browse the repository at this point in the history

  25. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    a217968 View commit details
    Browse the repository at this point in the history

  26. Remove unnecessary load 

    This is already done in the searcher
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    41835a5 View commit details
    Browse the repository at this point in the history

  27. Rename $load to $include 

    $load is the mechanism, $include is the actual important bit.
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    40da823 View commit details
    Browse the repository at this point in the history

  28. Typehint AbstractSearcher return value

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    2b5b14d View commit details
    Browse the repository at this point in the history

  29. Move $include out of searching / filtering 

    On second thought,  the searcher / filterer shouldn't be responsible for loading related items. It centralizes code, but isn't proper (and breaks `Discussion::setStateUser()`)
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    ba3994b View commit details
    Browse the repository at this point in the history

  30. Fix stupid mistakes

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    3d0d931 View commit details
    Browse the repository at this point in the history

  31. More fixes for stupid stuff, also temporarily loosen interface to avo… 

    …id BC breaks
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    947e5da View commit details
    Browse the repository at this point in the history

  32. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    993fbed View commit details
    Browse the repository at this point in the history

  33. Don't pass unused $include to filterer/searcher

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    ff4f227 View commit details
    Browse the repository at this point in the history

  34. Remove includes param from AbstractSearcher

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    5fb3f29 View commit details
    Browse the repository at this point in the history

  35. Add filter mutator params to docblock

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    5a4bc5a View commit details
    Browse the repository at this point in the history

  36. Capitalization fix

    @askvortsov1
    askvortsov1 committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    97ac81a View commit details
    Browse the repository at this point in the history