Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting posts/discussions by deleted user #2521

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

askvortsov1
Copy link
Sponsor Member

Fixes #2506

Making the $user argument nullable prevents this unnecessary exception, and doesn't introduce any issues since we check that $user exists as part of the method.

Making the $user argument nullable prevents this unnecessary exception, and doesn't introduce any issues since we check that $user exists as part of the method.
Copy link
Contributor

@tankerkiller125 tankerkiller125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@askvortsov1 askvortsov1 merged commit aae83c4 into master Jan 7, 2021
@askvortsov1 askvortsov1 deleted the as/2506-UserMetadataUpdater-accept-null-user branch January 7, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete a post or discussion from a deleted user
3 participants