Set this.changingState back to false in ExtensionPage if an error occurs

[dsevillamartin]

Fixes #2536

Changes proposed in this pull request:

• Set this.changingState = false in onerror handler.
• Only use this.changingState for Switch status & its loading attribute
  • do not take it into account in whether to show the ext settings as that makes it look bad (see reviewer focus below)

Reviewers should focus on:

I feel like we should instead get rid of changingState completely. It causes the UI to glitch out and there's no reason for the text & info shown to update while the "Please wait" modal is active and then be wrong.

hfdRh7iPce.mp4

Video:

UmCttTKrm5.mp4

Confirmed

• Frontend changes: tested on a local Flarum installation.

[askvortsov1]

I feel like we should instead get rid of changingState completely. It causes the UI to glitch out and there's no reason for the text & info shown to update while the "Please wait" modal is active and then be wrong.

I think I would prefer this too: we have a continuous stream of animation via the loading modal, so it's not like users wouldn't get visual confirmation that they're trying to activate/deactivate an extension.

That being said, it would be nice to keep the header switch itself enabling; perhaps changingState could be moved out of isEnabled, and directly into the "checked" criteria for the switch?

[dsevillamartin]

That being said, it would be nice to keep the header switch itself enabling; perhaps changingState could be moved out of isEnabled, and directly into the "checked" criteria for the switch?

I like this. I also set it to the loading attr because as we don't want the Enabled/Disabled text changing, and in case there's an issue with the modal not appearing or something, the user knows that it's possibly not fully enabled/disabled and it was in progress.

[dsevillamartin]

This currently has an issue - the switch does not go back to the original state after the error.

Nevermind, there's no issue. I removed the local dist changes and the original issue popped up 😂