Optional Dependencies #2579
Merged
Optional Dependencies #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrneDev
reviewed
Feb 16, 2021
askvortsov1
commented
Feb 16, 2021
askvortsov1
force-pushed
the
as/optional-dependencies
branch
from
5aad483
to
299ed62
Compare
SychO9
requested changes
Feb 19, 2021
There was a problem hiding this comment.
So I noticed an odd behaviour,
I created two dummy extensions that have flarum/tags as an optional dependency, I enabled both of them and observed the enabled extensions list order, looked fine and logical. I then proceeded to disable the tags extension, being an optional dependency it should not affect the other two extensions, however everytime I tried doing so one of the extensions (not always the same one) gets disabled.
Tracked it down to an issue in the extension order resolution algorithm.
SychO9
approved these changes
Feb 21, 2021
askvortsov1
added a commit
that referenced
this pull request
Feb 21, 2021
* Add and calculate optional dependencies * Add extension dependency resolver (Kahn's algorithm), plus unit tests * Resolve extension dependency on enable/disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1318
Changes proposed in this pull request:
Reviewers should focus on:
Confirmed
- [ ] Frontend changes: tested on a local Flarum installation.composer test).Required changes: