[A11Y] Fix nav drawer being focusable when off-screen on small viewports #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
changed the title
davwheat
added
the
type/accessibility
askvortsov1
requested changes
Mar 16, 2021
askvortsov1
reviewed
Mar 16, 2021
|
I'm not comfortable enough with combining JS & CSS code for animations (I struggled a lot with Composer open & close animation in my mithril 2 branch) 🙈 If it works and doesn't break other things (which it doesn't look to me like it would), I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2565
Progresses towards completion of #3360
Changes proposed in this pull request:
visibility: hiddenon mobile when the drawer is not open.visibility: visibleas drawer exits.visibility: hiddenonce transition is complete.In the GIFs below, keep an eye on the watched variables in the dev console to see the effect of the change.
Before
After
Confirmed