Use github markdown utils in core, support key handlers #2826
Conversation
This simplifies the markdown extension and allows BBCode to use these features. It also allows undoing stuff like inserting replies/mentions
Co-authored-by: David Wheatley <[email protected]>
Co-authored-by: David Wheatley <[email protected]>
Co-authored-by: David Wheatley <[email protected]>
Nice catch! Fixed |
|
|
||
| this.el.dispatchEvent(new CustomEvent('input', { bubbles: true, cancelable: true })); | ||
| items.add('submit', function (e) { | ||
| if ((e.metaKey || e.ctrlKey) && e.key === 'Enter') { |
There was a problem hiding this comment.
Is Win + Enter causing a post to submit intentional, as it seems like it will do.
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey
There was a problem hiding this comment.
In Markdown, we check against the user agent to decide between Cmd and Ctrl.
Maybe we could add the getOS helper I had in a PR a while back to make this info part of core and available to extensions instead of duplicating logic.
Something like app.operatingSystem or window.__operatingSystem?
There was a problem hiding this comment.
In the long term, I'd to introduce some form of "normalize keys" util like exists in prosemirror, which turns Meta-KEY into the appropriate cmd vs ctrl. I haven't found a library yet.
For now, I'm not sure this PR is the best place to change existing behavior?
There was a problem hiding this comment.
If this is the current action of MDArea/Prosmirror then I say we keep it this way for now and modify it later once we normalize things.
Fixes #2722
Fixes #2746
Background
Right now we have a mix of 3 systems:
Getting them to work together can be a pain. This PR combines (1) and (3), and the accompanying PR to markdown removes (2) for now. I hope to implement / support (2) in core eventually, since continuing lists is quite useful.
Changes proposed in this pull request:
Move the insertText and styleSelectedText utils to core
This simplifies the markdown extension and allows other extensions to use these features.
It also allows undoing stuff like inserting replies/mentions.
In future versions, I'd like to include support for continuing lists and indentation.
Confirmed
composer test).