-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core to use new Webpack config, flarum-tsconfig
, and build action
#2856
Conversation
flarum-tsconfig
flarum-tsconfig
flarum-tsconfig
, and build action
35d463b
to
5c1bf85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should BundleAnalyzer also be moved to webpack config?
Also, when we commit this, it should compile typings directly in this repo, right?
That might be a good idea, actually! Yes, typings will be added to this repo under |
Should we move the tooltip ones there? |
No, they should be automatically added as part of the typings compilation process. (About to double check that...) |
5c1bf85
to
5337437
Compare
Looks like We'll need to add it the |
I like this one. |
I was thinking the exact opposite! 😂 Changing to |
I don't have a strong preference. As long as renaming them to |
I kept with |
Are we doing this here, or in a separate PR? |
This allows us to have a moving tag, like first party actions have.
Might as well do it here while we're doing all the rest too |
PR opened: flarum/flarum-webpack-config#12 |
Before merging this, we need to tag and publish
flarum-webpack-config
and update the version here.