Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ModalManager and state to Typescript #3007

Merged
merged 11 commits into from
Oct 30, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Aug 9, 2021

Progresses #3533

Changes proposed in this pull request:

  • Rewrites files to TS
    • Fixes modal attrs being marked as required
  • Adds new isModalOpen() method

Reviewers should focus on:

Should we make closeTimeout private, or just mark it as @internal? I don't see any reason that people would use it.

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@davwheat davwheat added this to the 1.0.5 milestone Aug 9, 2021
@davwheat davwheat self-assigned this Aug 9, 2021
@SychO9 SychO9 modified the milestones: 1.0.5, 1.1 Aug 10, 2021
js/src/common/states/ModalManagerState.ts Show resolved Hide resolved
js/src/common/states/ModalManagerState.ts Outdated Show resolved Hide resolved
js/src/common/states/ModalManagerState.ts Show resolved Hide resolved
- Fixes `attrs` parameter being marked as required
- Add `isModalOpen` method
js/src/common/components/Modal.tsx Outdated Show resolved Hide resolved
js/src/common/components/Modal.tsx Show resolved Hide resolved
js/src/common/components/ModalManager.tsx Outdated Show resolved Hide resolved
@askvortsov1 askvortsov1 modified the milestones: 1.1, 1.2 Sep 28, 2021
@davwheat davwheat requested review from SychO9 and removed request for clarkwinkelmann October 14, 2021 16:15
js/src/common/components/Modal.tsx Outdated Show resolved Hide resolved
js/src/common/components/Modal.tsx Show resolved Hide resolved
Co-authored-by: David Sevilla Martin <[email protected]>
@davwheat davwheat merged commit 7db2d0f into master Oct 30, 2021
@davwheat davwheat deleted the dw/rewrite-modalmanager-ts branch October 30, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants