Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit height of code blocks #3012

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Limit height of code blocks #3012

merged 4 commits into from
Aug 11, 2021

Conversation

pierres
Copy link
Contributor

@pierres pierres commented Aug 11, 2021

Users often post lengthy code or configuration listings which makes following the actual discussion difficult. Therefore we limit a code block by half a screen while still being able to scroll through the code listing itself.

Users often post lengthy code or configuration listings which makes following the actual discussion difficult. Therefore we limit a code block by half a screen while still being able to scroll through the code listing itself.
@davwheat davwheat self-assigned this Aug 11, 2021
@davwheat davwheat added this to the 1.1 milestone Aug 11, 2021
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've wanted this done for a while 😍 gets hard to scroll when people post logs.

Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SychO9 Double-check you're happy with the compatibility change I made, otherwise good to merge 👍

Thank you @pierres!

@SychO9
Copy link
Member

SychO9 commented Aug 11, 2021

@davwheat fine by me 👍

@davwheat
Copy link
Member

Ohh hold off a moment... LESS doesn't like max

@davwheat
Copy link
Member

Tests should pass now... 🤞

@SychO9
Copy link
Member

SychO9 commented Aug 11, 2021

I always miss that when using vanilla CSS functions, LESS almost always has the same functions implemented that calculate the result when compiling.

@davwheat
Copy link
Member

Me too. It's a real pain 😕

@davwheat davwheat merged commit f1ba5e7 into flarum:master Aug 11, 2021
@davwheat davwheat modified the milestones: 1.1, 1.0.5 Aug 11, 2021
@pierres
Copy link
Contributor Author

pierres commented Aug 12, 2021

Thanks a lot. Next time I'll try not to forget about LESS and older browsers :-)

@SychO9 SychO9 modified the milestones: 1.0.5, 1.1 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants