Replace username with display name in more places #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
reviewed
Aug 21, 2021
|
This can be considered part of https://github.com/flarum/core/issues/1734 |
askvortsov1
approved these changes
Aug 21, 2021
SychO9
approved these changes
Aug 21, 2021
SychO9
reviewed
Aug 21, 2021
| app.alerts.show( | ||
| { type }, | ||
| app.translator.trans(message, { | ||
| user, |
There was a problem hiding this comment.
isn't this meant to be username: user.displayName() ?
There was a problem hiding this comment.
It's now using our "magic" translator behavior that automatically provides a username variable with the output of the username() helper function if you pass a user (which actually returns the display name). This is actually more consistent with the other uses of the translator.
There was a problem hiding this comment.
oh wow, I actually wasn't aware it was a thing lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Replaces instances of
usernamewhich have not been converted to use display name yet.The following were fixed:
I don't think any of these had an open issue.
Reviewers should focus on:
For the alert change I have kept the existing name
usernamefor the translation variable. I think that's what we have already done in all previous instances.Confirmed
composer test).