Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Default Settings Repository #3127

Merged
merged 18 commits into from
Oct 31, 2021
Merged

feat: Default Settings Repository #3127

merged 18 commits into from
Oct 31, 2021

Commits on Oct 26, 2021

  1. Create default settings extender

    @SychO9
    SychO9 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    b9c09d6 View commit details
    Browse the repository at this point in the history

  2. Deprecate migration addSettings helper

    @SychO9
    SychO9 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d30cb39 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Switch to an array of defaults

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    6aea45f View commit details
    Browse the repository at this point in the history

  2. Deprecate serializeToForum default parameter

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    9732b70 View commit details
    Browse the repository at this point in the history

  3. Fix early settings resolution issues

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    2ee1e69 View commit details
    Browse the repository at this point in the history

  4. Revert "Switch to an array of defaults" 

    This reverts commit 6aea45f
    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    e43a23a View commit details
    Browse the repository at this point in the history

  5. Make immutable

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    6b320e6 View commit details
    Browse the repository at this point in the history

  6. Rename container binding

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7ecddad View commit details
    Browse the repository at this point in the history

  7. Make it a repository

    @SychO9
    SychO9 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    f119eb7 View commit details
    Browse the repository at this point in the history

  8. Update src/Extend/Settings.php 

    Co-authored-by: Alexander Skvortsov <[email protected]>
    @SychO9 @askvortsov1
    SychO9 and askvortsov1 authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a7305a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Throw exception when trying to modify default setting

    @SychO9
    SychO9 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    af746f4 View commit details
    Browse the repository at this point in the history

  2. Deprecate SettingsRepositoryInterface@get default value

    @SychO9
    SychO9 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    6811126 View commit details
    Browse the repository at this point in the history

  3. Wrap DefaultSettingsRepository around the rest.

    @SychO9
    SychO9 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    31f8fd6 View commit details
    Browse the repository at this point in the history

  4. Improve extender phpdoc

    @SychO9
    SychO9 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    60bcaad View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. test: Null setting values should not be treated as unset and should b… 

    …e returned
    @SychO9
    SychO9 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    c7e03fb View commit details
    Browse the repository at this point in the history

  2. chore: Add comment

    @SychO9
    SychO9 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    8f859f3 View commit details
    Browse the repository at this point in the history

  3. chore: store defaults in a collection

    @SychO9
    SychO9 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    5fc9e0d View commit details
    Browse the repository at this point in the history

  4. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @luceos @StyleCIBot
    luceos authored and StyleCIBot committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    f1c5c9c View commit details
    Browse the repository at this point in the history