fix: Post--by-start-user
not working
#3356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This is an odd one, #3170 was supposed to fix this, but I'm not sure where I got
startUserId
from, that has never been part of the discussion frontend attributes. (and the title of that fix refers to the wrong class as well).This PR loads the author relationship by default to compare against.
Reviewers should focus on:
We could also just introduce the attribute above, instead of loading the relationship.
Necessity
Confirmed
composer test
).