Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple children to be passed to ConfirmDocumentUnload component #3372

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Lets you pass multiple children to the ConfirmDocumentUnload component through the use of a Mithril fragment.

Reviewers should focus on:

As far as I can see, the only reason this was not done before was because of the impression that this could only be done through a wrapping DOM component rather than a fragment.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Mar 31, 2022
@davwheat davwheat merged commit 803f4cc into main Apr 3, 2022
@davwheat davwheat deleted the dw/mult-children-unload branch April 3, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants