Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mentions): post mentions with deleted author not rendering #3432

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 20, 2022

Fixes #3427

Changes proposed in this pull request:
The issue details the problem and solution very well.
Remember to clear the cache when testing locally.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, having this logic separated is cleaner.

@SychO9 SychO9 changed the title fix: post mentions with deleted author not rendering fix(mentions): post mentions with deleted author not rendering Jun 2, 2022
@SychO9 SychO9 merged commit 0a3f449 into main Jun 2, 2022
@SychO9 SychO9 deleted the sm/3427-fix-post-mention-deleted-user-rendering branch June 2, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot mention post with deleted author
3 participants